Skip to content

Add more informative errors for null ElementCache#2600

Merged
labkey-tchad merged 2 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_plateEditorNpe
Aug 4, 2025
Merged

Add more informative errors for null ElementCache#2600
labkey-tchad merged 2 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_plateEditorNpe

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Aug 1, 2025 •
edited
Loading

Rationale

Some components are able to end up with a null element cache. Hopefully, adding some null checks to Component.elementCache will help narrow down what is happening.

java.lang.NullPointerException: Cannot read field "editableGrid" because the return value of "org.labkey.test.components.biologics.PlateEditor.elementCache()" is null
	at org.labkey.test.components.biologics.PlateEditor.getEditableGrid(PlateEditor.java:240)
	at org.labkey.test.components.biologics.PlateEditor.lambda$4(PlateEditor.java:251)
	at org.labkey.test.util.Timer.waitFor(Timer.java:91)
	at org.labkey.test.WebDriverWrapper.waitFor(WebDriverWrapper.java:2315)
	at org.labkey.test.components.biologics.PlateEditor.doAndWaitForGridColumnUpdate(PlateEditor.java:247)
	at org.labkey.test.pages.biologics.plates.BasePlateSetPage.doAndWaitForGridColumnUpdate(BasePlateSetPage.java:279)
	at org.labkey.test.components.biologics.CustomizePlateViewDialog.clickUpdateGrid(CustomizePlateViewDialog.java:29)
	at org.labkey.test.tests.biologics.plates.PlateSamplesTest.testAssayImportWithTransformScript(PlateSamplesTest.java:938)

Related Pull Requests

Changes

  • Add null checks to Component.elementCache
  • Add @NotNull annotations to overridden SearchContext methods

@labkey-tchad labkey-tchad mentioned this pull request Aug 1, 2025
Closed
labkey-chrisj
labkey-chrisj approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@labkey-chrisj labkey-chrisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope these work 😸

@labkey-tchad labkey-tchad merged commit 637dc78 into release25.7-SNAPSHOT Aug 4, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_plateEditorNpe branch August 4, 2025 23:53
@labkey-tchad labkey-tchad mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@labkey-chrisj labkey-chrisj labkey-chrisj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-tchad @labkey-chrisj